Skip to content

pipes - Tamira Kimberley Nkiru Diane - betsy #68

Open
tvojnar wants to merge 525 commits intoAda-C8:masterfrom
tvojnar:master
Open

pipes - Tamira Kimberley Nkiru Diane - betsy #68
tvojnar wants to merge 525 commits intoAda-C8:masterfrom
tvojnar:master

Conversation

@tvojnar
Copy link

@tvojnar tvojnar commented Oct 27, 2017

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question Answer
How did your team break up the work to be done? We split it up by models and controllers and stay within which one we were assigned to. When functionality overlapped we worked together. We also split things up by priority. We also paired on some of the more difficult problems.
How did your team utilize git to collaborate? We worked on branches and merged them using pull requests.
What did your group do to try to keep your code DRY while many people collaborated on it? Comments helped to keep our code dry. We tried to track any redundancies we saw. Keeping our code DRY as a group was one of our major challenges.
What was a technical challenge that you faced as a group? CSS overriding other peoples work if we didn't use specific enough styling tags. This was more of a problem because we we're all working on CSS at the same time. We also faced nested routes and many to many relationships together.
What was a team/personal challenge that you faced as a group? We had different communication styles, coding styles, and assumptions about group work that we had to work though. We also had to work through low moral when were getting started.
What could your team have done better? Communication! And more pairing. More communication around what we had worked on individually.
What was your application's ERD? (include a link) https://static1.squarespace.com/static/54bc2955e4b0b0eaa10e5a2b/59f3a40f109526e333fb41f6/59f3b5532774d1f13fb7d947/1509143897086/erd.jpg?format=2500w
What is your Trello URL? https://trello.com/b/bDjjaiEF/betsy
What is the Heroku URL of your deployed application? https://vineandbloom.herokuapp.com/products/new

tvojnar and others added 30 commits October 23, 2017 14:42
@tvojnar
wrote expected pass and fail test for the update action in the OrderI…
d473bc1 
…temController
@nkiruka
Added standard controller actions
224fa90
@nkiruka
created new model billings and ran migration
9ed3ab2
@nkiruka
Merge branch 'master' of https://github.com/tvojnar/betsy into billings
a8c6e06
@kimpossible1
fixed price issue
e95a7f2
@kimpossible1
merging master to my branch
1ec8a6b 
Merge branch 'master' of https://github.com/tvojnar/betsy into finishing_product_controller
@nkiruka
Added form_for to new view
fd2ce43
@kimpossible1
fixed edit page
e7c9183
@nkiruka
Added view partials for billing new and edit views
72a0387
@nkiruka
Added submit action to billing controller
3c1b89e
@tvojnar
can change the quantity of an order_item from the show page for order
d56c446
@tvojnar
wrote test stubs for all the tests I need to write for the update action
3a8eb79
@kimpossible1
fixed some small issues in product controller and tests
7302b24
@tvojnar
Have a failing test for updating quantity when it should
a5d2b29
@kimpossible1
updated controller tests for product
33d4076
@nkiruka
Added custom route for submit
8122484
@nkiruka
Updates
faa41a8
@nkiruka
Merge pull request #26 from tvojnar/billings
9f9f854 
Billings
@kimpossible1
merging with my branch Merge branch 'master' of https://github.com/tv…
dc17b1e 
…ojnar/betsy
@lenertzd
idk
3948f9e
@lenertzd
Merge branch 'master' of https://github.com/tvojnar/betsy into diane_…
ce10b25 
…new_day
@tvojnar
passing test for updating the quantity when the order_item exisits, i…
fd8bde5 
…s in the current Order, and update is provided valid data
@tvojnar
Passing test for not updating quantity when provided with invalid qua…
8478617 
…ntity data
@tvojnar
passing test for not updating quantity if new quantity requested is >…
431f12f 
… inventory
@tvojnar
changed the way the update action checks if the quantity requested is…
aeebf72 
… <= the inventory
@tvojnar
passing test for the update action no updating the OrderItem's quanti…
4adf005 
…ty if it is not in the current Order
@tvojnar
passing test for not updating the quantity if the OrderItem does not …
8f57b11 
…exist
@tvojnar
addded comments to the update controller action
90454be
@tvojnar
fixed merge conflict after pulling origin master so I can do a pull r…
332548a 
…equest
@tvojnar
Merge pull request #27 from tvojnar/change-quantity
1468e60 
Change quantity

Now you can change the quantity of an OrderItem in the current Order!
tvojnar and others added 22 commits October 27, 2017 11:25
@tvojnar
Merge pull request #56 from tvojnar/order-show-page-friday
26190b1 
Order show page friday
@kimpossible1
updates to merchant account page
fbc731c
@kimpossible1
Merge branch 'master' of https://github.com/tvojnar/betsy
3aa31a9
@kimpossible1
merchant account page
bb75894
@nkiruka
styling for buttons
9cb7854
@nkiruka
Merge branch 'master' of https://github.com/tvojnar/betsy
f34f5e9
@tvojnar
Add basic styling for flash messages
94c215b
@tvojnar
Merge pull request #57 from tvojnar/flash
87b9070 
Add basic styling for flash messages
@lenertzd
add styling to review read page
a0f7580
@kimpossible1
Fixed prod description bug
3ddfc0e
@lenertzd
Merge branch 'master' of https://github.com/tvojnar/betsy into diane_…
5f6597c 
…branch_tuesday
@lenertzdiane
Merge pull request #58 from tvojnar/diane_branch_tuesday
a2f4470 
Diane branch tuesday
@kimpossible1
update
b80c302
@tvojnar
Edit product index page to change title based on filter
6c91758
@tvojnar
fixed merge conflict in merchant.scss
0f8832c
@tvojnar
Merge pull request #59 from tvojnar/edit-product-index-page
799a6de 
Edit product index page to change title based on filter
@lenertzd
fix order paid total issue on confirmation page
c0788ca
@lenertzdiane
Merge pull request #60 from tvojnar/diane_branch_tuesday
40ded4c 
fix order paid total issue on confirmation page
@kimpossible1
product show page
651deac
@kimpossible1
Merge branch 'master' of https://github.com/tvojnar/betsy
30a97e6
@tvojnar
fixed merge conflict in current order view
85da490
@tvojnar
last updates
cda4e0c
@PilgrimMemoirs
Copy link

PilgrimMemoirs commented Nov 3, 2017

bEtsy

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with all members contributing Well Done
Answered comprehension questions Well Done
Trello board is created and utilized in project management Mostly Good - make sure to include names on all tasks - easier to know who to go to if there's a question about that feature. It can also reflect pairing, where commits are only under one name.
Heroku instance is online Well Done - oauth not working, did you set environment variables?
General
Nested routes follow RESTful conventions Well Done
oAuth used for User authentication Well Done
Functionality restricted based on user roles Well Done
Products can be added and removed from cart Mostly Good - Adding the same item twice creates two different order_products instead of updating the one that's there. I was able to checkout a product that only stated it had 36 available, by adding 7 the first time and 30 the second time, within the same cart.
Users can view past orders Not Complete
Merchants can add, edit and view their products Well Done
Errors are reported to the user Well Done
Order Functionality
Reduces products' inventory Well Done
Cannot order products that are out of stock Mostly Good - see note above on 'products can be added and removed from a cart'
Changes order state Well Done
Clears current cart Well Done
Database
ERD includes all necessary tables and relationships Mostly Good - Needs to be updated. Is missing Billings table. Photo isn't very clear, after white boarding use a digital tool so that you can update as necessary and have something easier to reference.
Table relationships Well Done
Models
Validation rules for Models Well Done - Opportunity for more in billing
Business logic is in the models Mostly Good - Merchant methods are good, but if they're instance methods, do you need to pass the merchant instant in as an argument? If it's being called on a merchant instance, you can refer to that instance in it's method using self.
Controllers
Controller Filters used to DRY up controller code Well Done
Testing 162 tests, 399 assertions, 1 failures, 0 errors, 0 skips
Model Testing Mostly Good - Be sure to also have positive and negative test cases for validations like review only having a rating as an integer, with that integer needing to be between your set range.
Controller Testing Mostly Good
Session Testing Mostly Good
SimpleCov at 90% for controller and model tests Well Done - 89.54% (I'll let the .45% slide for now)
Front-end
The app is styled to create an attractive user interface Well Done
The app layout uses Foundation's Grid Well Done
Content is organized with HTML5 semantic tags Mostly Good - be mindful of indentation
CSS is DRY Mostly Good - when defining fonts, create one ruleset for it and apply as many selectors that are going to use it - easier to change later on. Similar for something like text-align: center; Avoid static measurements.
Overall
Great job coming together and achieving the requirements of the project.

IMPORTANT: Whoever submitted the PR (and thus will get the notification about this feedback) should share this with their teammates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Pipes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tvojnar @PilgrimMemoirs @droberts-sea @nkiruka @kimpossible1 @lenertzd @lenertzdiane